summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2013-10-25 06:14:43 -0700
committerMichal Marek <mmarek@suse.cz>2013-11-06 22:30:03 +0100
commit849464d1ba97a13b388fee9a69fbbeee175b349c (patch)
tree155fa37c210749cb9e17304213d5648a4403bd7b /scripts
parent21cf6e584ce35b79374581e6344dd7c74f8b4a2b (diff)
downloadop-kernel-dev-849464d1ba97a13b388fee9a69fbbeee175b349c.zip
op-kernel-dev-849464d1ba97a13b388fee9a69fbbeee175b349c.tar.gz
kbuild: replace unbounded sprintf call in modpost
The modpost tool could overflow its stack buffer if someone was running with an insane shell environment. Regardless, it's technically a bug, so this fixes it to truncate the string instead of seg-faulting. Found by Coverity. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts')
-rw-r--r--scripts/mod/sumversion.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c
index 9dfcd6d9..deb2994 100644
--- a/scripts/mod/sumversion.c
+++ b/scripts/mod/sumversion.c
@@ -416,7 +416,7 @@ void get_src_version(const char *modname, char sum[], unsigned sumlen)
basename = strrchr(modname, '/') + 1;
else
basename = modname;
- sprintf(filelist, "%s/%.*s.mod", modverdir,
+ snprintf(filelist, sizeof(filelist), "%s/%.*s.mod", modverdir,
(int) strlen(basename) - 2, basename);
file = grab_file(filelist, &len);
OpenPOWER on IntegriCloud