diff options
author | Oleg Nesterov <oleg@redhat.com> | 2015-06-04 16:22:16 -0400 |
---|---|---|
committer | Paul Moore <pmoore@redhat.com> | 2015-06-04 16:22:16 -0400 |
commit | 9e7c8f8c62c1e1cda203b5bfaba4575b141e42e7 (patch) | |
tree | ffbe4be8b34649fd07898137aeb74404f4fa093f /scripts | |
parent | cded3fffbeab777e6ad2ec05d4a3b62c5caca0f3 (diff) | |
download | op-kernel-dev-9e7c8f8c62c1e1cda203b5bfaba4575b141e42e7.zip op-kernel-dev-9e7c8f8c62c1e1cda203b5bfaba4575b141e42e7.tar.gz |
signals: don't abuse __flush_signals() in selinux_bprm_committed_creds()
selinux_bprm_committed_creds()->__flush_signals() is not right, we
shouldn't clear TIF_SIGPENDING unconditionally. There can be other
reasons for signal_pending(): freezing(), JOBCTL_PENDING_MASK, and
potentially more.
Also change this code to check fatal_signal_pending() rather than
SIGNAL_GROUP_EXIT, it looks a bit better.
Now we can kill __flush_signals() before it finds another buggy user.
Note: this code looks racy, we can flush a signal which was sent after
the task SID has been updated.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions