summaryrefslogtreecommitdiffstats
path: root/scripts/kconfig
diff options
context:
space:
mode:
authorBen Hutchings <ben@decadent.org.uk>2011-03-19 04:26:10 +0000
committerMichal Marek <mmarek@suse.cz>2011-04-08 12:05:20 +0200
commit466de9183570fe9fd21ef167951488fc9d513fcb (patch)
tree0c0aa271be45daf6e5bfc3abd2aa41b7cf64e7cb /scripts/kconfig
parent0ce790e7d736cedc563e1fb4e998babf5a4dbc3d (diff)
downloadop-kernel-dev-466de9183570fe9fd21ef167951488fc9d513fcb.zip
op-kernel-dev-466de9183570fe9fd21ef167951488fc9d513fcb.tar.gz
kconfig: Avoid buffer underrun in choice input
commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default value for choice input') fixed some cases where kconfig would select the wrong option from a choice with a single valid option and thus enter an infinite loop. However, this broke the test for user input of the form 'N?', because when kconfig selects the single valid option the input is zero-length and the test will read the byte before the input buffer. If this happens to contain '?' (as it will in a mips build on Debian unstable today) then kconfig again enters an infinite loop. Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Cc: stable@kernel.org [2.6.17+] Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/kconfig')
-rw-r--r--scripts/kconfig/conf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 659326c..006ad81 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -332,7 +332,7 @@ static int conf_choice(struct menu *menu)
}
if (!child)
continue;
- if (line[strlen(line) - 1] == '?') {
+ if (line[0] && line[strlen(line) - 1] == '?') {
print_help(child);
continue;
}
OpenPOWER on IntegriCloud