diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-01-27 21:41:27 +0100 |
|---|---|---|
| committer | Michal Marek <mmarek@suse.cz> | 2012-02-25 00:07:11 +0100 |
| commit | cd0207a7bfd29016a4eeb0b0203fa900b41e4eee (patch) | |
| tree | 2d479b9c71e07ac46d8c03b3f9253aa9b2448f56 /scripts/coccinelle/free | |
| parent | 53302c1dfa8a911b88e68634ed56fcf577037fac (diff) | |
| download | op-kernel-dev-cd0207a7bfd29016a4eeb0b0203fa900b41e4eee.zip op-kernel-dev-cd0207a7bfd29016a4eeb0b0203fa900b41e4eee.tar.gz | |
coccinelle: semantic patch for missing iounmap
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Diffstat (limited to 'scripts/coccinelle/free')
| -rw-r--r-- | scripts/coccinelle/free/iounmap.cocci | 67 |
1 files changed, 67 insertions, 0 deletions
diff --git a/scripts/coccinelle/free/iounmap.cocci b/scripts/coccinelle/free/iounmap.cocci new file mode 100644 index 0000000..5384f4ba --- /dev/null +++ b/scripts/coccinelle/free/iounmap.cocci @@ -0,0 +1,67 @@ +/// Find missing iounmaps. +/// +//# This only signals a missing iounmap when there is an iounmap later +//# in the same function. +//# False positives can be due to loops. +// +// Confidence: Moderate +// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. +// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. +// URL: http://coccinelle.lip6.fr/ +// Comments: +// Options: + +virtual context +virtual org +virtual report + +@iom@ +expression e; +statement S,S1; +int ret; +position p1,p2,p3; +@@ + +e = \(ioremap@p1\|ioremap_nocache@p1\)(...) +... when != iounmap(e) +if (<+...e...+>) S +... when any + when != iounmap(e) + when != if (...) { ... iounmap(e); ... } +( + if (ret == 0) S1 +| +if (...) + { ... + return 0; } +| +if (...) + { ... + return <+...e...+>; } +| +*if@p2 (...) + { ... when != iounmap(e) + when forall + return@p3 ...; } +) +... when any +iounmap(e); + +@script:python depends on org@ +p1 << iom.p1; +p2 << iom.p2; +p3 << iom.p3; +@@ + +cocci.print_main("ioremap",p1) +cocci.print_secs("if",p2) +cocci.print_secs("needed iounmap",p3) + +@script:python depends on report@ +p1 << iom.p1; +p2 << iom.p2; +p3 << iom.p3; +@@ + +msg = "ERROR: missing iounmap; ioremap on line %s and execution via conditional on line %s" % (p1[0].line,p2[0].line) +coccilib.report.print_report(p3[0],msg) |
