summaryrefslogtreecommitdiffstats
path: root/scripts/coccinelle/alloc/kzalloc-simple.cocci
diff options
context:
space:
mode:
authorMichal Marek <mmarek@suse.cz>2010-06-12 00:01:31 +0200
committerMichal Marek <mmarek@suse.cz>2010-06-12 00:01:31 +0200
commit6ff21517c001f38b02393ad9dc92decbaee209fa (patch)
tree7cd980dd3d869613669847ccda444459f6fdf0e4 /scripts/coccinelle/alloc/kzalloc-simple.cocci
parentb396aa03084b51f6822052a8070703287f198360 (diff)
parent82c4340b0a3ccf090ef38fa111363018cf0594c8 (diff)
downloadop-kernel-dev-6ff21517c001f38b02393ad9dc92decbaee209fa.zip
op-kernel-dev-6ff21517c001f38b02393ad9dc92decbaee209fa.tar.gz
Merge branch 'kbuild/coccinelle' into kbuild/misc
Diffstat (limited to 'scripts/coccinelle/alloc/kzalloc-simple.cocci')
-rw-r--r--scripts/coccinelle/alloc/kzalloc-simple.cocci82
1 files changed, 82 insertions, 0 deletions
diff --git a/scripts/coccinelle/alloc/kzalloc-simple.cocci b/scripts/coccinelle/alloc/kzalloc-simple.cocci
new file mode 100644
index 0000000..2eae828
--- /dev/null
+++ b/scripts/coccinelle/alloc/kzalloc-simple.cocci
@@ -0,0 +1,82 @@
+///
+/// kzalloc should be used rather than kmalloc followed by memset 0
+///
+// Confidence: High
+// Copyright: (C) 2009-2010 Julia Lawall, Nicolas Palix, DIKU. GPLv2.
+// Copyright: (C) 2009-2010 Gilles Muller, INRIA/LiP6. GPLv2.
+// URL: http://coccinelle.lip6.fr/rules/kzalloc.html
+// Options: -no_includes -include_headers
+//
+// Keywords: kmalloc, kzalloc
+// Version min: < 2.6.12 kmalloc
+// Version min: 2.6.14 kzalloc
+//
+
+virtual context
+virtual patch
+virtual org
+virtual report
+
+//----------------------------------------------------------
+// For context mode
+//----------------------------------------------------------
+
+@depends on context@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+@@
+
+* x = (T)kmalloc(E1,E2);
+ if ((x==NULL) || ...) S
+* memset((T2)x,0,E1);
+
+//----------------------------------------------------------
+// For patch mode
+//----------------------------------------------------------
+
+@depends on patch@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+@@
+
+- x = (T)kmalloc(E1,E2);
++ x = kzalloc(E1,E2);
+ if ((x==NULL) || ...) S
+- memset((T2)x,0,E1);
+
+//----------------------------------------------------------
+// For org mode
+//----------------------------------------------------------
+
+@r depends on org || report@
+type T, T2;
+expression x;
+expression E1,E2;
+statement S;
+position p;
+@@
+
+ x = (T)kmalloc@p(E1,E2);
+ if ((x==NULL) || ...) S
+ memset((T2)x,0,E1);
+
+@script:python depends on org@
+p << r.p;
+x << r.x;
+@@
+
+msg="%s" % (x)
+msg_safe=msg.replace("[","@(").replace("]",")")
+coccilib.org.print_todo(p[0], msg_safe)
+
+@script:python depends on report@
+p << r.p;
+x << r.x;
+@@
+
+msg="WARNING: kzalloc should be used for %s, instead of kmalloc/memset" % (x)
+coccilib.report.print_report(p[0], msg)
OpenPOWER on IntegriCloud