diff options
author | Steven Rostedt <srostedt@redhat.com> | 2012-01-13 17:53:40 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2012-01-13 18:01:48 -0500 |
commit | 364212fddaaa60c5a64f67a0f5624ad996ecc8a0 (patch) | |
tree | 47ce8b894b493e59d142f91f5b2c943e48d3d29b /scripts/checkpatch.pl | |
parent | d060d963e88f3e990cec2fe5214de49de9a49eca (diff) | |
download | op-kernel-dev-364212fddaaa60c5a64f67a0f5624ad996ecc8a0.zip op-kernel-dev-364212fddaaa60c5a64f67a0f5624ad996ecc8a0.tar.gz |
kconfig/streamline-config.pl: Fix parsing Makefile with variables
Thomas Lange reported that when he did a 'make localmodconfig', his
config was missing the brcmsmac driver, even though he had the module
loaded.
Looking into this, I found the file:
drivers/net/wireless/brcm80211/brcmsmac/Makefile
had the following in the Makefile:
MODULEPFX := brcmsmac
obj-$(CONFIG_BRCMSMAC) += $(MODULEPFX).o
The way streamline-config.pl works, is parsing all the
obj-$(CONFIG_FOO) += foo.o
lines to find that CONFIG_FOO belongs to the module foo.ko.
But in this case, the brcmsmac.o was not used, but a variable in its place.
By changing streamline-config.pl to remember defined variables in Makefiles
and substituting them when they are used in the obj-X lines, allows
Thomas (and others) to have their brcmsmac module stay configured
when it is loaded and running "make localmodconfig".
Reported-by: Thomas Lange <thomas-lange2@gmx.de>
Tested-by: Thomas Lange <thomas-lange2@gmx.de>
Cc: Arend van Spriel <arend@broadcom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'scripts/checkpatch.pl')
0 files changed, 0 insertions, 0 deletions