summaryrefslogtreecommitdiffstats
path: root/samples
diff options
context:
space:
mode:
authorKeith Busch <keith.busch@intel.com>2016-07-13 11:45:02 -0600
committerJens Axboe <axboe@fb.com>2016-07-14 08:48:08 -0700
commit32f0c4afb4363e31dad49202f1554ba591d649f2 (patch)
treeb0b789ae8f42f0f987776671f8828c4e36a63280 /samples
parent92d21ac74a9e3c09b0b01c764e530657e4c85c49 (diff)
downloadop-kernel-dev-32f0c4afb4363e31dad49202f1554ba591d649f2.zip
op-kernel-dev-32f0c4afb4363e31dad49202f1554ba591d649f2.tar.gz
nvme: Remove RCU namespace protection
We can't sleep with RCU read lock held, but we need to do potentially blocking stuff to namespace queues when iterating the list. This patch removes the RCU locking and holds a mutex instead. To prevent deadlocks, this patch removes holding the mutex during namespace scanning and removal. The unlocked namespace scanning is made safe by holding a reference to the namespace being scanned. List iteration that does IO has to be unlocked to allow error recovery. The caller must ensure the list can not be manipulated during such an event, so this patch adds a comment explaining this requirement to the only function that iterates an unlocked list. All callers currently meet this requirement, so no further changes required. List iterations that do not do IO can safely use the lock since it couldn't block recovery from missing forced IO completions. Reported-by: Ming Lin <mlin at kernel.org> [fixes 0bf77e9 nvme: switch to RCU freeing the namespace] Signed-off-by: Keith Busch <keith.busch@intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud