summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorAlex Elder <elder@inktank.com>2012-11-29 08:37:03 -0600
committerAlex Elder <elder@inktank.com>2012-12-17 08:37:19 -0600
commit7d5f24812bd182a2471cb69c1c2baf0648332e1f (patch)
tree412d6180cf9e0c14559b827331808414f767bfd3 /net
parent42382b709bd1d143b9f0fa93e0a3a1f2f4210707 (diff)
downloadop-kernel-dev-7d5f24812bd182a2471cb69c1c2baf0648332e1f.zip
op-kernel-dev-7d5f24812bd182a2471cb69c1c2baf0648332e1f.tar.gz
ceph: don't reference req after put
In __unregister_request(), there is a call to list_del_init() referencing a request that was the subject of a call to ceph_osdc_put_request() on the previous line. This is not safe, because the request structure could have been freed by the time we reach the list_del_init(). Fix this by reversing the order of these lines. Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-off-by: Sage Weil <sage@inktank.com>
Diffstat (limited to 'net')
-rw-r--r--net/ceph/osd_client.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index 7ebfe13..ac7be72 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -871,9 +871,9 @@ static void __unregister_request(struct ceph_osd_client *osdc,
req->r_osd = NULL;
}
+ list_del_init(&req->r_req_lru_item);
ceph_osdc_put_request(req);
- list_del_init(&req->r_req_lru_item);
if (osdc->num_requests == 0) {
dout(" no requests, canceling timeout\n");
__cancel_osd_timeout(osdc);
OpenPOWER on IntegriCloud