diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2014-12-19 06:20:57 +0000 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2014-12-19 13:40:07 +0100 |
| commit | 51bda2bca53b265715ca1852528f38dc67429d9a (patch) | |
| tree | 2e8721c2ce2556a9d4d636f4b5497af938f7b4e2 /net | |
| parent | 004fa5ed08cc5d3188db42c05d6b80feaae004c2 (diff) | |
| download | op-kernel-dev-51bda2bca53b265715ca1852528f38dc67429d9a.zip op-kernel-dev-51bda2bca53b265715ca1852528f38dc67429d9a.tar.gz | |
Bluetooth: hidp_connection_add() unsafe use of l2cap_pi()
it's OK after we'd verified the sockets, but not before that.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bluetooth/hidp/core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index cc25d0b..07348e1 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -1314,13 +1314,14 @@ int hidp_connection_add(struct hidp_connadd_req *req, { struct hidp_session *session; struct l2cap_conn *conn; - struct l2cap_chan *chan = l2cap_pi(ctrl_sock->sk)->chan; + struct l2cap_chan *chan; int ret; ret = hidp_verify_sockets(ctrl_sock, intr_sock); if (ret) return ret; + chan = l2cap_pi(ctrl_sock->sk)->chan; conn = NULL; l2cap_chan_lock(chan); if (chan->conn) |
