diff options
| author | Alexander Duyck <alexander.h.duyck@intel.com> | 2013-07-11 13:12:22 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-07-11 16:12:03 -0700 |
| commit | 8c91e162e058bb91b7766f26f4d5823a21941026 (patch) | |
| tree | 430170c009409c6ea04eae1718e232a2a8c0621a /net | |
| parent | 88d4f419a43b474a4524f41f55c36bee13416bdd (diff) | |
| download | op-kernel-dev-8c91e162e058bb91b7766f26f4d5823a21941026.zip op-kernel-dev-8c91e162e058bb91b7766f26f4d5823a21941026.tar.gz | |
gre: Fix MTU sizing check for gretap tunnels
This change fixes an MTU sizing issue seen with gretap tunnels when non-gso
packets are sent from the interface.
In my case I was able to reproduce the issue by simply sending a ping of
1421 bytes with the gretap interface created on a device with a standard
1500 mtu.
This fix is based on the fact that the tunnel mtu is already adjusted by
dev->hard_header_len so it would make sense that any packets being compared
against that mtu should also be adjusted by hard_header_len and the tunnel
header instead of just the tunnel header.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Reported-by: Cong Wang <amwang@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ip_tunnel.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index 945734b..ca1cb2d 100644 --- a/net/ipv4/ip_tunnel.c +++ b/net/ipv4/ip_tunnel.c @@ -476,7 +476,7 @@ static int tnl_update_pmtu(struct net_device *dev, struct sk_buff *skb, struct rtable *rt, __be16 df) { struct ip_tunnel *tunnel = netdev_priv(dev); - int pkt_size = skb->len - tunnel->hlen; + int pkt_size = skb->len - tunnel->hlen - dev->hard_header_len; int mtu; if (df) |
