diff options
| author | Dan Siemon <dan@coverfire.com> | 2011-03-15 13:56:07 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-03-15 18:53:54 -0700 |
| commit | 4a2b9c3756077c05dd8666e458a751d2248b61b6 (patch) | |
| tree | 9d074adc7c94a7fdb3be69e1e0572184f76056a3 /net | |
| parent | 7313714775a6411402f63261c05fbb4ee3d5b64a (diff) | |
| download | op-kernel-dev-4a2b9c3756077c05dd8666e458a751d2248b61b6.zip op-kernel-dev-4a2b9c3756077c05dd8666e458a751d2248b61b6.tar.gz | |
net_sched: fix ip_tos2prio
ECN support incorrectly maps ECN BESTEFFORT packets to TC_PRIO_FILLER
(1) instead of TC_PRIO_BESTEFFORT (0)
This means ECN enabled flows are placed in pfifo_fast/prio low priority
band, giving ECN enabled flows [ECT(0) and CE codepoints] higher drop
probabilities.
This is rather unfortunate, given we would like ECN being more widely
used.
Ref : http://www.coverfire.com/archives/2011/03/13/pfifo_fast-and-ecn/
Signed-off-by: Dan Siemon <dan@coverfire.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Täht <d@taht.net>
Cc: Jonathan Morton <chromatix99@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 209989c..870b518 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -204,7 +204,7 @@ static struct dst_ops ipv4_dst_ops = { const __u8 ip_tos2prio[16] = { TC_PRIO_BESTEFFORT, - ECN_OR_COST(FILLER), + ECN_OR_COST(BESTEFFORT), TC_PRIO_BESTEFFORT, ECN_OR_COST(BESTEFFORT), TC_PRIO_BULK, |
