diff options
| author | Wu Fengguang <fengguang.wu@intel.com> | 2015-09-10 06:57:12 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-09-09 17:21:01 -0700 |
| commit | 52fe51f8523751da0e79c85350c47eb3bb94da5b (patch) | |
| tree | d603742cef32c5565f2a73d755c41c97611064d3 /net | |
| parent | 792aec47d59d951865cc617a97b6e6be53d4b977 (diff) | |
| download | op-kernel-dev-52fe51f8523751da0e79c85350c47eb3bb94da5b.zip op-kernel-dev-52fe51f8523751da0e79c85350c47eb3bb94da5b.tar.gz | |
ipv6: fix ifnullfree.cocci warnings
net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
CC: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/route.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 34539d3..53617d7 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2942,8 +2942,7 @@ cleanup: list_for_each_entry_safe(nh, nh_safe, &rt6_nh_list, next) { if (nh->rt6_info) dst_free(&nh->rt6_info->dst); - if (nh->mxc.mx) - kfree(nh->mxc.mx); + kfree(nh->mxc.mx); list_del(&nh->next); kfree(nh); } |
