summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2013-04-05 08:13:30 +0000
committerPablo Neira Ayuso <pablo@netfilter.org>2013-04-06 14:03:18 +0200
commit3a7b21eaf4fb3c971bdb47a98f570550ddfe4471 (patch)
tree2b2f4450f88603a83fb2c31bb48fbc1ea1c29761 /net
parent53f63189b1110559dce8c1ee29e8abc3e31f7630 (diff)
downloadop-kernel-dev-3a7b21eaf4fb3c971bdb47a98f570550ddfe4471.zip
op-kernel-dev-3a7b21eaf4fb3c971bdb47a98f570550ddfe4471.tar.gz
netfilter: nf_ct_sip: don't drop packets with offsets pointing outside the packet
Some Cisco phones create huge messages that are spread over multiple packets. After calculating the offset of the SIP body, it is validated to be within the packet and the packet is dropped otherwise. This breaks operation of these phones. Since connection tracking is supposed to be passive, just let those packets pass unmodified and untracked. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/nf_conntrack_sip.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/net/netfilter/nf_conntrack_sip.c b/net/netfilter/nf_conntrack_sip.c
index 0e7d423..e0c4373 100644
--- a/net/netfilter/nf_conntrack_sip.c
+++ b/net/netfilter/nf_conntrack_sip.c
@@ -1593,10 +1593,8 @@ static int sip_help_tcp(struct sk_buff *skb, unsigned int protoff,
end += strlen("\r\n\r\n") + clen;
msglen = origlen = end - dptr;
- if (msglen > datalen) {
- nf_ct_helper_log(skb, ct, "incomplete/bad SIP message");
- return NF_DROP;
- }
+ if (msglen > datalen)
+ return NF_ACCEPT;
ret = process_sip_msg(skb, ct, protoff, dataoff,
&dptr, &msglen);
OpenPOWER on IntegriCloud