summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorNivedita Singhvi <niv@us.ibm.com>2013-01-28 17:52:37 +0000
committerDavid S. Miller <davem@davemloft.net>2013-01-29 15:43:04 -0500
commit2aeef18d37aa8c0bfca169d4ede1790d972bf649 (patch)
treee38ca04c8441572c52a5d8db7bc0e20376ec42a1 /net
parent5e98a36ed4bf6ea396170e3af0dd4fcbe51d772f (diff)
downloadop-kernel-dev-2aeef18d37aa8c0bfca169d4ede1790d972bf649.zip
op-kernel-dev-2aeef18d37aa8c0bfca169d4ede1790d972bf649.tar.gz
tcp: Increment LISTENOVERFLOW and LISTENDROPS in tcp_v4_conn_request()
We drop a connection request if the accept backlog is full and there are sufficient packets in the syn queue to warrant starting drops. Increment the appropriate counters so this isn't silent, for accurate stats and help in debugging. This patch assumes LINUX_MIB_LISTENDROPS is a superset of/includes the counter LINUX_MIB_LISTENOVERFLOWS. Signed-off-by: Nivedita Singhvi <niv@us.ibm.com> Acked-by: Vijay Subramanian <subramanian.vijay@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/tcp_ipv4.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 70b09ef..629937d 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1500,8 +1500,11 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
* clogging syn queue with openreqs with exponentially increasing
* timeout.
*/
- if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1)
+ if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) {
+ NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
+ NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
goto drop;
+ }
req = inet_reqsk_alloc(&tcp_request_sock_ops);
if (!req)
OpenPOWER on IntegriCloud