summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorRami Rosen <rosenr@marvell.com>2012-08-27 23:39:24 +0000
committerDavid S. Miller <davem@davemloft.net>2012-08-31 16:24:02 -0400
commitd1a53dfd114a6c53464de116cdab88d934bfe92f (patch)
tree9c0424486348fb56cf87aa91063bd3f336ca9c00 /net
parent98d75c3724f9b37cdfdb85f821e10edcb743959e (diff)
downloadop-kernel-dev-d1a53dfd114a6c53464de116cdab88d934bfe92f.zip
op-kernel-dev-d1a53dfd114a6c53464de116cdab88d934bfe92f.tar.gz
net: fix documentation of skb_needs_linearize().
skb_needs_linearize() does not check highmem DMA as it does not call illegal_highdma() anymore, so there is no need to mention highmem DMA here. (Indeed, ~NETIF_F_SG flag, which is checked in skb_needs_linearize(), can be set when illegal_highdma() returns true, and we are assured that illegal_highdma() is invoked prior to skb_needs_linearize() as skb_needs_linearize() is a static method called only once. But ~NETIF_F_SG can be set not only there in this same invocation path. It can also be set when can_checksum_protocol() returns false). see commit 02932ce9e2c136e6fab2571c8e0dd69ae8ec9853, Convert skb_need_linearize() to use precomputed features. Signed-off-by: Rami Rosen <rosenr@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/dev.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index a5fc3e3..b1e6d63 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2184,9 +2184,7 @@ EXPORT_SYMBOL(netif_skb_features);
/*
* Returns true if either:
* 1. skb has frag_list and the device doesn't support FRAGLIST, or
- * 2. skb is fragmented and the device does not support SG, or if
- * at least one of fragments is in highmem and device does not
- * support DMA from it.
+ * 2. skb is fragmented and the device does not support SG.
*/
static inline int skb_needs_linearize(struct sk_buff *skb,
int features)
OpenPOWER on IntegriCloud