summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>2008-10-20 03:33:24 -0700
committerDavid S. Miller <davem@davemloft.net>2008-10-20 03:33:24 -0700
commit311670f3ea90115f2f1840e3e9770ed71e06e6c3 (patch)
treec17fe256a1a3c6dde687b7093666ecaad030b3be /net
parent6def1eb48101600884ebed56de03041fadc7a985 (diff)
downloadop-kernel-dev-311670f3ea90115f2f1840e3e9770ed71e06e6c3.zip
op-kernel-dev-311670f3ea90115f2f1840e3e9770ed71e06e6c3.tar.gz
netfilter: snmp nat leaks memory in case of failure
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/netfilter/nf_nat_snmp_basic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/netfilter/nf_nat_snmp_basic.c b/net/ipv4/netfilter/nf_nat_snmp_basic.c
index ffeaffc..8303e4b 100644
--- a/net/ipv4/netfilter/nf_nat_snmp_basic.c
+++ b/net/ipv4/netfilter/nf_nat_snmp_basic.c
@@ -742,6 +742,7 @@ static unsigned char snmp_object_decode(struct asn1_ctx *ctx,
*obj = kmalloc(sizeof(struct snmp_object) + len,
GFP_ATOMIC);
if (*obj == NULL) {
+ kfree(p);
kfree(id);
if (net_ratelimit())
printk("OOM in bsalg (%d)\n", __LINE__);
OpenPOWER on IntegriCloud