summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2014-08-07 22:17:07 +0200
committerDavid S. Miller <davem@davemloft.net>2014-08-07 16:02:58 -0700
commit6f2c9bd85eee30fd77e6c65c097769ad0d6d7352 (patch)
tree5e0ed046be13ca7ad269ff24c9a8b24d70775898 /net
parentc891c24c62b376e508a45eeeb9f37e1b94173126 (diff)
downloadop-kernel-dev-6f2c9bd85eee30fd77e6c65c097769ad0d6d7352.zip
op-kernel-dev-6f2c9bd85eee30fd77e6c65c097769ad0d6d7352.tar.gz
net: gianfar: fix reference counting for phy_node
The line before the changed if condition is: priv->phy_node = of_parse_phandle(np, "phy-handle", 0); . If this call succeeds priv->phy_node must not be overwritten in the if block; otherwise the reference to the node returned by of_parse_phandle is lost. So add a check that the if block isn't executed in this case. Furthermore in the fixed phy case no reference is aquired for phy_node resulting in an of_node_put without holding a reference. To fix that, get a reference on the MAC dt node. Fixes: be40364544bd ("gianfar: use the new fixed PHY helpers") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud