summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDave Jones <davej@redhat.com>2013-11-14 10:41:01 -0500
committerPablo Neira Ayuso <pablo@netfilter.org>2013-11-25 22:42:18 +0100
commitb49faea7655ec10ade15d7d007e4218ca578a513 (patch)
treed9d47ff514ce78d14d487b07c26e8fef76423058 /net
parent2c7a9dc1641664173211c4ebc5db510a08684c46 (diff)
downloadop-kernel-dev-b49faea7655ec10ade15d7d007e4218ca578a513.zip
op-kernel-dev-b49faea7655ec10ade15d7d007e4218ca578a513.tar.gz
netfilter: ipset: fix incorret comparison in hash_netnet4_data_equal()
Both sides of the comparison are the same, looks like a cut-and-paste error. Spotted by Coverity. Signed-off-by: Dave Jones <davej@fedoraproject.org> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/ipset/ip_set_hash_netnet.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/ipset/ip_set_hash_netnet.c b/net/netfilter/ipset/ip_set_hash_netnet.c
index 2bc2dec..6226803 100644
--- a/net/netfilter/ipset/ip_set_hash_netnet.c
+++ b/net/netfilter/ipset/ip_set_hash_netnet.c
@@ -59,7 +59,7 @@ hash_netnet4_data_equal(const struct hash_netnet4_elem *ip1,
u32 *multi)
{
return ip1->ipcmp == ip2->ipcmp &&
- ip2->ccmp == ip2->ccmp;
+ ip1->ccmp == ip2->ccmp;
}
static inline int
OpenPOWER on IntegriCloud