diff options
author | Anders Kaseorg <andersk@mit.edu> | 2009-04-23 16:49:33 -0400 |
---|---|---|
committer | Sam Ravnborg <sam@ravnborg.org> | 2009-05-01 10:54:05 +0200 |
commit | b614a697dc17dff82f140d72d21a095f810fa7fb (patch) | |
tree | b16edfeaddf7e808d6fa4b71ee11e497968476b2 /net | |
parent | c993971f4a7dc7ae43963aecb958395353c109ae (diff) | |
download | op-kernel-dev-b614a697dc17dff82f140d72d21a095f810fa7fb.zip op-kernel-dev-b614a697dc17dff82f140d72d21a095f810fa7fb.tar.gz |
kbuild, modpost: Check the section flags, to catch missing "ax"/"aw"
When you put
.section ".foo"
in an assembly file instead of
.section "foo", "ax"
, one of the possible symptoms is that modpost will see an
ld-generated section name ".foo.1" in section_rel() or section_rela().
But this heuristic has two problems: it will miss a bad section that
has no relocations, and it will incorrectly flag many gcc-generated
sections as bad when compiling with -ffunction-sections
-fdata-sections.
On mips it fixes a lot of bogus warnings with gcc 4.4.0 lije this one:
WARNING: crypto/cryptd.o (.text.T.349): unexpected section name.
So instead of checking whether the section name matches a particular
pattern, we directly check for a missing SHF_ALLOC in the section
flags.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Tested-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions