summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorMike Waychison <mikew@google.com>2011-08-10 21:59:57 -0700
committerDavid S. Miller <davem@davemloft.net>2011-08-10 21:59:57 -0700
commitf0e3d0689da401f7d1981c2777a714ba295ea5ff (patch)
treea8b2311c0cf7573c22d99c6917c08e77b225d637 /net
parent56c07271307b4a20802005692b2b70dfe13d72e8 (diff)
downloadop-kernel-dev-f0e3d0689da401f7d1981c2777a714ba295ea5ff.zip
op-kernel-dev-f0e3d0689da401f7d1981c2777a714ba295ea5ff.tar.gz
tcp: initialize variable ecn_ok in syncookies path
Using a gcc 4.4.3, warnings are emitted for a possibly uninitialized use of ecn_ok. This can happen if cookie_check_timestamp() returns due to not having seen a timestamp. Defaulting to ecn off seems like a reasonable thing to do in this case, so initialized ecn_ok to false. Signed-off-by: Mike Waychison <mikew@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/syncookies.c2
-rw-r--r--net/ipv6/syncookies.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/syncookies.c b/net/ipv4/syncookies.c
index 92bb943..3bc5c8f 100644
--- a/net/ipv4/syncookies.c
+++ b/net/ipv4/syncookies.c
@@ -276,7 +276,7 @@ struct sock *cookie_v4_check(struct sock *sk, struct sk_buff *skb,
int mss;
struct rtable *rt;
__u8 rcv_wscale;
- bool ecn_ok;
+ bool ecn_ok = false;
if (!sysctl_tcp_syncookies || !th->ack || th->rst)
goto out;
diff --git a/net/ipv6/syncookies.c b/net/ipv6/syncookies.c
index 89d5bf8..ac83896 100644
--- a/net/ipv6/syncookies.c
+++ b/net/ipv6/syncookies.c
@@ -165,7 +165,7 @@ struct sock *cookie_v6_check(struct sock *sk, struct sk_buff *skb)
int mss;
struct dst_entry *dst;
__u8 rcv_wscale;
- bool ecn_ok;
+ bool ecn_ok = false;
if (!sysctl_tcp_syncookies || !th->ack || th->rst)
goto out;
OpenPOWER on IntegriCloud