diff options
author | Gerrit Renker <gerrit@erg.abdn.ac.uk> | 2007-09-26 11:26:04 -0300 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-10-10 16:52:41 -0700 |
commit | 727ecc5faaf6e976fc841649821c865ebd1e822d (patch) | |
tree | 7e12432db774b0278fb641b44f4528f523094ad4 /net | |
parent | 2e86908f7dfb71b67ca4739d9a6c678b83b01078 (diff) | |
download | op-kernel-dev-727ecc5faaf6e976fc841649821c865ebd1e822d.zip op-kernel-dev-727ecc5faaf6e976fc841649821c865ebd1e822d.tar.gz |
[DCCP]: Add FIXME for send_delayed_ack
This adds a FIXME to signal that the function dccp_send_delayed_ack is nowhere
used in the entire DCCP/CCID code.
Using a delayed Ack timer is suggested in 11.3 of RFC 4340, but it has also
rather subtle implications for the Ack-Ratio-accounting.
CCID2 does not use this (maybe it should).
I think leaving the function in is good, in case someone wants to implement
this.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/dccp/dccp.h | 1 | ||||
-rw-r--r-- | net/dccp/output.c | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index bd4645b..f62eeb3 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h @@ -209,7 +209,6 @@ extern void dccp_v4_send_check(struct sock *sk, int len, struct sk_buff *skb); extern int dccp_retransmit_skb(struct sock *sk, struct sk_buff *skb); extern void dccp_send_ack(struct sock *sk); -extern void dccp_send_delayed_ack(struct sock *sk); extern void dccp_reqsk_send_ack(struct sk_buff *sk, struct request_sock *rsk); extern void dccp_send_sync(struct sock *sk, const u64 seq, diff --git a/net/dccp/output.c b/net/dccp/output.c index 6e23d5b..d0c9ec6 100644 --- a/net/dccp/output.c +++ b/net/dccp/output.c @@ -477,6 +477,7 @@ void dccp_send_ack(struct sock *sk) EXPORT_SYMBOL_GPL(dccp_send_ack); +/* FIXME: Is this still necessary (11.3) - currently nowhere used by DCCP. */ void dccp_send_delayed_ack(struct sock *sk) { struct inet_connection_sock *icsk = inet_csk(sk); |