summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2013-10-08 15:53:07 -0400
committerJ. Bruce Fields <bfields@redhat.com>2013-10-08 15:56:23 -0400
commit3be34555fa294483202483c4b171a8d335447187 (patch)
treecdcf8e2787d05c7fe4acfc42400e7242dbc9bc4e /net
parentc66080ad0a9295eaf0246a46949619f92c75faaa (diff)
downloadop-kernel-dev-3be34555fa294483202483c4b171a8d335447187.zip
op-kernel-dev-3be34555fa294483202483c4b171a8d335447187.tar.gz
svcrpc: fix error-handling on badd gssproxy downcall
For every other problem here we bail out with an error, but here for some reason we're setting a negative cache entry (with, note, an undefined expiry). It seems simplest just to bail out in the same way as we do in other cases. Cc: Simo Sorce <simo@redhat.com> Reported-by: Andi Kleen <andi@firstfloor.org> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/auth_gss/svcauth_gss.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c
index 09fb638..008cdad 100644
--- a/net/sunrpc/auth_gss/svcauth_gss.c
+++ b/net/sunrpc/auth_gss/svcauth_gss.c
@@ -1167,8 +1167,8 @@ static int gss_proxy_save_rsc(struct cache_detail *cd,
if (!ud->found_creds) {
/* userspace seem buggy, we should always get at least a
* mapping to nobody */
- dprintk("RPC: No creds found, marking Negative!\n");
- set_bit(CACHE_NEGATIVE, &rsci.h.flags);
+ dprintk("RPC: No creds found!\n");
+ goto out;
} else {
/* steal creds */
OpenPOWER on IntegriCloud