summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorEd Swierk <eswierk@arastra.com>2008-12-01 12:24:43 +0000
committerDavid S. Miller <davem@davemloft.net>2008-12-03 21:06:42 -0800
commitcb52deba12f27af90a46d2f8667a64888118a888 (patch)
tree91b9e3fa5d0670e98811a43a1f2ad6e1cbe668f7 /net
parenta316084c2f18fd5371f81cfcfc8348a71c4a6fe8 (diff)
downloadop-kernel-dev-cb52deba12f27af90a46d2f8667a64888118a888.zip
op-kernel-dev-cb52deba12f27af90a46d2f8667a64888118a888.tar.gz
forcedeth: power down phy when interface is down
Bring the physical link down when the interface is down by placing the PHY in power-down state, unless WOL is enabled. This mirrors the behavior of other drivers including e1000 and tg3. Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link lights both on the NIC and the switch to go out when they bring an interface down. Furthermore, even though the phy is powered on, autonegotiation stops working, so a normally gigabit link might suddenly become 100 Mbit half-duplex when the interface goes down, and become gigabit when it comes up again. Ayaz said: I would not include this patch until further testing is performed. NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it could have adverse affects on certain phys. Arthur Jones said: I just ran across this patch. Tested on a Marvell 88E1121R (GigE PHY) and works great. This is a very important feature for me. Signed-off-by: Ed Swierk <eswierk@arastra.com> Tested-by: Arthur Jones <ajones@riverbed.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud