diff options
author | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2008-02-08 09:50:08 +0900 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-02-11 10:20:53 -0600 |
commit | 7d5d408c77cee95d1380511de46b7a4c8dc2211d (patch) | |
tree | bec3464f501145718b2426efde10b02229de4552 /net | |
parent | 19af35546de68c872dcb687613e0902a602cb20e (diff) | |
download | op-kernel-dev-7d5d408c77cee95d1380511de46b7a4c8dc2211d.zip op-kernel-dev-7d5d408c77cee95d1380511de46b7a4c8dc2211d.tar.gz |
[SCSI] advansys: fix overrun_buf aligned bug
struct asc_dvc_var needs overrun buffer to be placed on an 8 byte
boundary. advansys defines struct asc_dvc_var:
struct asc_dvc_var {
...
uchar overrun_buf[ASC_OVERRUN_BSIZE] __aligned(8);
The problem is that struct asc_dvc_var is placed on
shost->hostdata. So if the hostdata is not on an 8 byte boundary, the
advansys crashes. The hostdata is placed on a sizeof(unsigned long)
boundary so the 8 byte boundary is not garanteed with x86_32.
With 2.6.23 and 2.6.24, the hostdata is on an 8 byte boundary by
chance, but with the current git, it's not.
This patch removes overrun_buf static array and use kzalloc.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions