summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorPavel Emelyanov <xemul@openvz.org>2007-10-15 12:54:15 -0700
committerDavid S. Miller <davem@davemloft.net>2007-10-15 12:54:15 -0700
commit4ae289444b968b4cefd776ada8da519ce10e56fa (patch)
tree06aa4ff04bb1acdb64c29fc4b28a5cf91b1d57b8 /net
parentf1673ca52c04f1b311abe03fd67cd4d650d19435 (diff)
downloadop-kernel-dev-4ae289444b968b4cefd776ada8da519ce10e56fa.zip
op-kernel-dev-4ae289444b968b4cefd776ada8da519ce10e56fa.tar.gz
[NEIGH]: Ensure that pneigh_lookup is protected with RTNL
The pnigh_lookup is used to lookup proxy entries and to create them in case lookup failed. However, the "creation" code does not perform the re-lookup after GFP_KERNEL allocation. This is done because the code is expected to be protected with the RTNL lock, so add the assertion (mainly to address future questions from new network developers like me :) ). Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/neighbour.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index c52df85..cd3af59 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -481,6 +481,8 @@ struct pneigh_entry * pneigh_lookup(struct neigh_table *tbl, const void *pkey,
if (!creat)
goto out;
+ ASSERT_RTNL();
+
n = kmalloc(sizeof(*n) + key_len, GFP_KERNEL);
if (!n)
goto out;
OpenPOWER on IntegriCloud