summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2006-07-12 13:29:56 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2006-07-12 13:59:04 -0700
commitb47b2ec19892ffc2b06ebf138ed4aa141275a1c2 (patch)
tree86642bccfbfdeb004a1b14b28c6ea15ee091de87 /net
parent4b260a98f1afc74cd6b73ce0616d76b441dbe8c5 (diff)
downloadop-kernel-dev-b47b2ec19892ffc2b06ebf138ed4aa141275a1c2.zip
op-kernel-dev-b47b2ec19892ffc2b06ebf138ed4aa141275a1c2.tar.gz
[IPV4]: Fix error handling for fib_insert_node call
The error handling around fib_insert_node was broken because we always zeroed the error before checking it. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/fib_trie.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 1cb6530..23fb9d9 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -1252,8 +1252,8 @@ fn_trie_insert(struct fib_table *tb, struct rtmsg *r, struct kern_rta *rta,
*/
if (!fa_head) {
- fa_head = fib_insert_node(t, &err, key, plen);
err = 0;
+ fa_head = fib_insert_node(t, &err, key, plen);
if (err)
goto out_free_new_fa;
}
OpenPOWER on IntegriCloud