summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJohan Hedberg <johan.hedberg@intel.com>2015-04-02 13:41:07 +0300
committerMarcel Holtmann <marcel@holtmann.org>2015-04-02 16:09:27 +0200
commit444c6dd54d81edf81c606f571cb52eff4d47fa99 (patch)
treedc665d1e9ac8a254f96553cf70985b564b3cad0d /net
parent64dd374eac154f747623b256c59ecaf5affba724 (diff)
downloadop-kernel-dev-444c6dd54d81edf81c606f571cb52eff4d47fa99.zip
op-kernel-dev-444c6dd54d81edf81c606f571cb52eff4d47fa99.tar.gz
Bluetooth: Add clarifying comment to command status handling
When dealing with HCI command status events, the reasoning for trying to mark a request as complete if no specific event is being waited for and status was success is not self-evident. This patch adds a clarifying comment above the if-statement. Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net')
-rw-r--r--net/bluetooth/hci_event.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 7c0f992..87e5bee 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -3124,6 +3124,12 @@ static void hci_cmd_status_evt(struct hci_dev *hdev, struct sk_buff *skb)
if (ev->ncmd && !test_bit(HCI_RESET, &hdev->flags))
atomic_set(&hdev->cmd_cnt, 1);
+ /* Indicate request completion if the command failed. Also, if
+ * we're not waiting for a special event and we get a success
+ * command status we should try to flag the request as completed
+ * (since for this kind of commands there will not be a command
+ * complete event).
+ */
if (ev->status ||
(hdev->sent_cmd && !bt_cb(hdev->sent_cmd)->req.event))
hci_req_cmd_complete(hdev, opcode, ev->status);
OpenPOWER on IntegriCloud