summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2008-07-21 18:45:34 -0700
committerDavid S. Miller <davem@davemloft.net>2008-07-21 18:45:34 -0700
commitb32d13102d39ed411d152a7ffcc5f66d5b3b1b49 (patch)
tree5db024bc2defe8440ea67c16dce65c4082ff4b98 /net
parentebb36a978131810c98e7198b1187090c697cf99f (diff)
downloadop-kernel-dev-b32d13102d39ed411d152a7ffcc5f66d5b3b1b49.zip
op-kernel-dev-b32d13102d39ed411d152a7ffcc5f66d5b3b1b49.tar.gz
tcp: Fix bitmask test in tcp_syn_options()
As reported by Alexey Dobriyan: CHECK net/ipv4/tcp_output.c net/ipv4/tcp_output.c:475:7: warning: dubious: !x & y And sparse is damn right! if (unlikely(!OPTION_TS & opts->options)) ^^^ size += TCPOLEN_SACKPERM_ALIGNED; OPTION_TS is (1 << 1), so condition will never trigger. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/tcp_output.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 1fa683c..a00532d 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -472,7 +472,7 @@ static unsigned tcp_syn_options(struct sock *sk, struct sk_buff *skb,
}
if (likely(sysctl_tcp_sack)) {
opts->options |= OPTION_SACK_ADVERTISE;
- if (unlikely(!OPTION_TS & opts->options))
+ if (unlikely(!(OPTION_TS & opts->options)))
size += TCPOLEN_SACKPERM_ALIGNED;
}
OpenPOWER on IntegriCloud