summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorNelson Elhage <nelhage@ksplice.com>2010-12-08 10:13:55 -0800
committerDavid S. Miller <davem@davemloft.net>2010-12-08 12:13:42 -0800
commit0c62fc6dd02c8d793c75ae76a9b6881fc36388ad (patch)
tree49dbe734dc75fe318ca83e2eae823fbeae10dc48 /net
parent083384755252cde25af187acf1807a0f5edb901f (diff)
downloadop-kernel-dev-0c62fc6dd02c8d793c75ae76a9b6881fc36388ad.zip
op-kernel-dev-0c62fc6dd02c8d793c75ae76a9b6881fc36388ad.tar.gz
econet: Do the correct cleanup after an unprivileged SIOCSIFADDR.
We need to drop the mutex and do a dev_put, so set an error code and break like the other paths, instead of returning directly. Signed-off-by: Nelson Elhage <nelhage@ksplice.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/econet/af_econet.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c
index 13992e1..f180371 100644
--- a/net/econet/af_econet.c
+++ b/net/econet/af_econet.c
@@ -661,8 +661,10 @@ static int ec_dev_ioctl(struct socket *sock, unsigned int cmd, void __user *arg)
err = 0;
switch (cmd) {
case SIOCSIFADDR:
- if (!capable(CAP_NET_ADMIN))
- return -EPERM;
+ if (!capable(CAP_NET_ADMIN)) {
+ err = -EPERM;
+ break;
+ }
edev = dev->ec_ptr;
if (edev == NULL) {
OpenPOWER on IntegriCloud