summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorNicolas Cavallari <nicolas.cavallari@green-communications.fr>2014-10-30 10:09:53 +0100
committerDavid S. Miller <davem@davemloft.net>2014-10-30 19:20:40 -0400
commitfa19c2b050ab5254326f5fc07096dd3c6a8d5d58 (patch)
tree17263248a697a04a00ac4b128df7ed4c34287ba2 /net
parente327c225c911529898ec300cb96d2088893de3df (diff)
downloadop-kernel-dev-fa19c2b050ab5254326f5fc07096dd3c6a8d5d58.zip
op-kernel-dev-fa19c2b050ab5254326f5fc07096dd3c6a8d5d58.tar.gz
ipv4: Do not cache routing failures due to disabled forwarding.
If we cache them, the kernel will reuse them, independently of whether forwarding is enabled or not. Which means that if forwarding is disabled on the input interface where the first routing request comes from, then that unreachable result will be cached and reused for other interfaces, even if forwarding is enabled on them. The opposite is also true. This can be verified with two interfaces A and B and an output interface C, where B has forwarding enabled, but not A and trying ip route get $dst iif A from $src && ip route get $dst iif B from $src Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr> Reviewed-by: Julian Anastasov <ja@ssi.bg> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/route.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 2d4ae46..6a2155b 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1798,6 +1798,7 @@ local_input:
no_route:
RT_CACHE_STAT_INC(in_no_route);
res.type = RTN_UNREACHABLE;
+ res.fi = NULL;
goto local_input;
/*
OpenPOWER on IntegriCloud