diff options
| author | Mathias Krause <minipli@googlemail.com> | 2012-09-19 11:33:38 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-09-20 18:08:39 -0400 |
| commit | 4c87308bdea31a7b4828a51f6156e6f721a1fcc9 (patch) | |
| tree | ca428f394170c09015dc982c3371c04de0749c81 /net/xfrm | |
| parent | 9db273f45686218e055a3738f3311048cbb54fee (diff) | |
| download | op-kernel-dev-4c87308bdea31a7b4828a51f6156e6f721a1fcc9.zip op-kernel-dev-4c87308bdea31a7b4828a51f6156e6f721a1fcc9.tar.gz | |
xfrm_user: fix info leak in copy_to_user_auth()
copy_to_user_auth() fails to initialize the remainder of alg_name and
therefore discloses up to 54 bytes of heap memory via netlink to
userland.
Use strncpy() instead of strcpy() to fill the trailing bytes of alg_name
with null bytes.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/xfrm')
| -rw-r--r-- | net/xfrm/xfrm_user.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index d12b625..40dd50d 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -742,7 +742,7 @@ static int copy_to_user_auth(struct xfrm_algo_auth *auth, struct sk_buff *skb) return -EMSGSIZE; algo = nla_data(nla); - strcpy(algo->alg_name, auth->alg_name); + strncpy(algo->alg_name, auth->alg_name, sizeof(algo->alg_name)); memcpy(algo->alg_key, auth->alg_key, (auth->alg_key_len + 7) / 8); algo->alg_key_len = auth->alg_key_len; |
