diff options
author | David Ward <david.ward@ll.mit.edu> | 2013-04-11 13:47:15 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-04-12 15:10:48 -0400 |
commit | fb745e9a037895321781d066aa24757ceabf9df9 (patch) | |
tree | 1166ef2a488b5e1afbd1ee71df493fb593adf167 /net/x25/x25_in.c | |
parent | 3be8fbab18fbc06b6ff94a56f9c225e29ea64a73 (diff) | |
download | op-kernel-dev-fb745e9a037895321781d066aa24757ceabf9df9.zip op-kernel-dev-fb745e9a037895321781d066aa24757ceabf9df9.tar.gz |
net/802/mrp: fix possible race condition when calling mrp_pdu_queue()
(Adapted from a very similar change to net/802/garp.c by Cong Wang.)
mrp_pdu_queue() should ways be called with the applicant spin lock.
mrp_uninit_applicant() only holds the rtnl lock which is not enough;
a race is possible because mrp_rcv() is called in BH context:
mrp_rcv()
|->mrp_pdu_parse_msg()
|->mrp_pdu_parse_vecattr()
|->mrp_pdu_parse_vecattr_event()
|-> mrp_attr_event()
|-> mrp_pdu_append_vecattr_event()
|-> mrp_pdu_queue()
Cc: Cong Wang <amwang@redhat.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/x25/x25_in.c')
0 files changed, 0 insertions, 0 deletions