summaryrefslogtreecommitdiffstats
path: root/net/wireless
diff options
context:
space:
mode:
authorWANG Cong <xiyou.wangcong@gmail.com>2015-02-13 13:56:53 -0800
committerDavid S. Miller <davem@davemloft.net>2015-02-15 08:30:10 -0800
commit7afb8886a05be68e376655539a064ec672de8a8e (patch)
tree80a30b31cb6062fb572cfe748556a8974badf973 /net/wireless
parentd95e2fe0ffa3b4325ddd11095f46d0c0b96450f5 (diff)
downloadop-kernel-dev-7afb8886a05be68e376655539a064ec672de8a8e.zip
op-kernel-dev-7afb8886a05be68e376655539a064ec672de8a8e.tar.gz
rtnetlink: call ->dellink on failure when ->newlink exists
Ignacy reported that when eth0 is down and add a vlan device on top of it like: ip link add link eth0 name eth0.1 up type vlan id 1 We will get a refcount leak: unregister_netdevice: waiting for eth0.1 to become free. Usage count = 2 The problem is when rtnl_configure_link() fails in rtnl_newlink(), we simply call unregister_device(), but for stacked device like vlan, we almost do nothing when we unregister the upper device, more work is done when we unregister the lower device, so call its ->dellink(). Reported-by: Ignacy Gawedzki <ignacy.gawedzki@green-communications.fr> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wireless')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud