diff options
author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2011-11-27 15:29:44 +0200 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-11-28 13:46:41 -0500 |
commit | 2a1e0fd175dcfd72096ba9291d31e3b1b5342e60 (patch) | |
tree | 75d1125cffd90d1af3213aa089049139a04b5536 /net/wireless/reg.c | |
parent | d305a6557b2c4dca0110f05ffe745b1ef94adb80 (diff) | |
download | op-kernel-dev-2a1e0fd175dcfd72096ba9291d31e3b1b5342e60.zip op-kernel-dev-2a1e0fd175dcfd72096ba9291d31e3b1b5342e60.tar.gz |
mac80211: fix race between the AGG SM and the Tx data path
When a packet is supposed to sent be as an a-MPDU, mac80211 sets
IEEE80211_TX_CTL_AMPDU to let the driver know. On the other
hand, mac80211 configures the driver for aggregration with the
ampdu_action callback.
There is race between these two mechanisms since the following
scenario can occur when the BA agreement is torn down:
Tx softIRQ drv configuration
========== =================
check OPERATIONAL bit
Set the TX_CTL_AMPDU bit in the packet
clear OPERATIONAL bit
stop Tx AGG
Pass Tx packet to the driver.
In that case the driver would get a packet with TX_CTL_AMPDU set
although it has already been notified that the BA session has been
torn down.
To fix this, we need to synchronize all the Qdisc activity after we
cleared the OPERATIONAL bit. After that step, all the following
packets will be buffered until the driver reports it is ready to get
new packets for this RA / TID. This buffering allows not to run into
another race that would send packets with TX_CTL_AMPDU unset while
the driver hasn't been requested to tear down the BA session yet.
This race occurs in practice and iwlwifi complains with a WARN_ON
when it happens.
Cc: stable@kernel.org
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/wireless/reg.c')
0 files changed, 0 insertions, 0 deletions