diff options
| author | Wei Yongjun <weiyj.lk@gmail.com> | 2016-07-28 02:07:49 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-07-30 20:38:22 -0700 |
| commit | 6b65bc29721dee21e963cde3a83369bd09ba5358 (patch) | |
| tree | c82fcc4dbbc212910b1a833abb7a1f69c472afd7 /net/tipc/monitor.c | |
| parent | 9d594b395808accfaafa9b572e2716e037274c2a (diff) | |
| download | op-kernel-dev-6b65bc29721dee21e963cde3a83369bd09ba5358.zip op-kernel-dev-6b65bc29721dee21e963cde3a83369bd09ba5358.tar.gz | |
tipc: fix imbalance read_unlock_bh in __tipc_nl_add_monitor()
In the error handling case of nla_nest_start() failed read_unlock_bh()
is called to unlock a lock that had not been taken yet. sparse warns
about the context imbalance as the following:
net/tipc/monitor.c:799:23: warning:
context imbalance in '__tipc_nl_add_monitor' - different lock contexts for basic block
Fixes: cf6f7e1d5109 ('tipc: dump monitor attributes')
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/monitor.c')
| -rw-r--r-- | net/tipc/monitor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/monitor.c b/net/tipc/monitor.c index be70a57..b62caa1 100644 --- a/net/tipc/monitor.c +++ b/net/tipc/monitor.c @@ -794,10 +794,10 @@ int __tipc_nl_add_monitor(struct net *net, struct tipc_nl_msg *msg, return 0; attr_msg_full: + read_unlock_bh(&mon->lock); nla_nest_cancel(msg->skb, attrs); msg_full: genlmsg_cancel(msg->skb, hdr); - read_unlock_bh(&mon->lock); return -EMSGSIZE; } |
