summaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2006-11-20 17:23:01 -0800
committerDavid S. Miller <davem@sunset.davemloft.net>2006-12-02 21:27:02 -0800
commit8cec6b80664eb20b0c033fd20d2c7ed15621437f (patch)
tree8bfe0e2539f221e724f5c5de543c3bf2c5912373 /net/sctp
parentb3f5b3b6654422bb0a6ef745fe4d11a4f01d006a (diff)
downloadop-kernel-dev-8cec6b80664eb20b0c033fd20d2c7ed15621437f.zip
op-kernel-dev-8cec6b80664eb20b0c033fd20d2c7ed15621437f.tar.gz
[SCTP]: We need to be careful when copying to sockaddr_storage.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r--net/sctp/associola.c2
-rw-r--r--net/sctp/socket.c8
2 files changed, 5 insertions, 5 deletions
diff --git a/net/sctp/associola.c b/net/sctp/associola.c
index fa7cda4..39471d3 100644
--- a/net/sctp/associola.c
+++ b/net/sctp/associola.c
@@ -733,7 +733,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc,
* user.
*/
memset(&addr, 0, sizeof(struct sockaddr_storage));
- flip_to_n((union sctp_addr *)&addr, &transport->ipaddr_h);
+ memcpy(&addr, &transport->ipaddr, transport->af_specific->sockaddr_len);
event = sctp_ulpevent_make_peer_addr_change(asoc, &addr,
0, spc_state, error, GFP_ATOMIC);
if (event)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index e527267..adbe531 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3202,8 +3202,8 @@ static int sctp_getsockopt_sctp_status(struct sock *sk, int len,
status.sstat_outstrms = asoc->c.sinit_num_ostreams;
status.sstat_fragmentation_point = asoc->frag_point;
status.sstat_primary.spinfo_assoc_id = sctp_assoc2id(transport->asoc);
- flip_to_n((union sctp_addr *)&status.sstat_primary.spinfo_address,
- &transport->ipaddr_h);
+ memcpy(&status.sstat_primary.spinfo_address, &transport->ipaddr,
+ transport->af_specific->sockaddr_len);
/* Map ipv4 address into v4-mapped-on-v6 address. */
sctp_get_pf_specific(sk->sk_family)->addr_v4map(sctp_sk(sk),
(union sctp_addr *)&status.sstat_primary.spinfo_address);
@@ -4173,8 +4173,8 @@ static int sctp_getsockopt_primary_addr(struct sock *sk, int len,
if (!asoc->peer.primary_path)
return -ENOTCONN;
- flip_to_n((union sctp_addr *)&prim.ssp_addr,
- &asoc->peer.primary_path->ipaddr_h);
+ memcpy(&prim.ssp_addr, &asoc->peer.primary_path->ipaddr,
+ asoc->peer.primary_path->af_specific->sockaddr_len);
sctp_get_pf_specific(sk->sk_family)->addr_v4map(sp,
(union sctp_addr *)&prim.ssp_addr);
OpenPOWER on IntegriCloud