summaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>2017-01-13 18:31:15 -0200
committerDavid S. Miller <davem@davemloft.net>2017-01-16 13:51:40 -0500
commitcdfb1a9f30aaf43cfcecbb6c4061cd3807a4e086 (patch)
tree787cb59a24cddd1b38a42f7e1122e0ec7f979fc3 /net/sctp
parent11d05ac1dfb2e51e21c403f19790bf96809b2714 (diff)
downloadop-kernel-dev-cdfb1a9f30aaf43cfcecbb6c4061cd3807a4e086.zip
op-kernel-dev-cdfb1a9f30aaf43cfcecbb6c4061cd3807a4e086.tar.gz
sctp: remove useless code from sctp_apply_peer_addr_params
sctp_frag_point() doesn't store anything, and thus just calling it cannot do anything useful. sctp_apply_peer_addr_params is only called by sctp_setsockopt_peer_addr_params. When operating on an asoc, sctp_setsockopt_peer_addr_params will call sctp_apply_peer_addr_params once for the asoc, and then once for each transport this asoc has, meaning that the frag_point will be recomputed when updating the transports and calling it when updating the asoc is not necessary. IOW, no action is needed here and we can remove this call. Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Reviewed-by: Xin Long <lucien.xin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r--net/sctp/socket.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 318c678..635e034 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -2430,7 +2430,6 @@ static int sctp_apply_peer_addr_params(struct sctp_paddrparams *params,
sctp_assoc_sync_pmtu(sctp_opt2sk(sp), asoc);
} else if (asoc) {
asoc->pathmtu = params->spp_pathmtu;
- sctp_frag_point(asoc, params->spp_pathmtu);
} else {
sp->pathmtu = params->spp_pathmtu;
}
OpenPOWER on IntegriCloud