summaryrefslogtreecommitdiffstats
path: root/net/sctp
diff options
context:
space:
mode:
authorVlad Yasevich <vladislav.yasevich@hp.com>2010-09-15 10:00:26 -0400
committerDavid S. Miller <davem@davemloft.net>2010-09-17 16:47:56 -0700
commit4bdab43323b459900578b200a4b8cf9713ac8fab (patch)
tree7a732994407ebb88698845ee36dbf98c062af49e /net/sctp
parent2507136f74f70a4869bd4f525d48715ae66db43d (diff)
downloadop-kernel-dev-4bdab43323b459900578b200a4b8cf9713ac8fab.zip
op-kernel-dev-4bdab43323b459900578b200a4b8cf9713ac8fab.tar.gz
sctp: Do not reset the packet during sctp_packet_config().
sctp_packet_config() is called when getting the packet ready for appending of chunks. The function should not touch the current state, since it's possible to ping-pong between two transports when sending, and that can result packet corruption followed by skb overlfow crash. Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
-rw-r--r--net/sctp/output.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c
index a646681..bcc4590 100644
--- a/net/sctp/output.c
+++ b/net/sctp/output.c
@@ -92,7 +92,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet,
SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__,
packet, vtag);
- sctp_packet_reset(packet);
packet->vtag = vtag;
if (ecn_capable && sctp_packet_empty(packet)) {
OpenPOWER on IntegriCloud