diff options
| author | Lance Richardson <lrichard@redhat.com> | 2016-08-23 11:40:52 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-08-23 17:22:53 -0700 |
| commit | 232cb53a45965f8789fbf0a9a1962f8c67ab1a3c (patch) | |
| tree | c38b98c67c82791ae2612d4883bb5d8b72f632dc /net/sctp | |
| parent | a8184003c0bb1d6362c2af76c560b3caae6832cb (diff) | |
| download | op-kernel-dev-232cb53a45965f8789fbf0a9a1962f8c67ab1a3c.zip op-kernel-dev-232cb53a45965f8789fbf0a9a1962f8c67ab1a3c.tar.gz | |
sctp: fix overrun in sctp_diag_dump_one()
The function sctp_diag_dump_one() currently performs a memcpy()
of 64 bytes from a 16 byte field into another 16 byte field. Fix
by using correct size, use sizeof to obtain correct size instead
of using a hard-coded constant.
Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file")
Signed-off-by: Lance Richardson <lrichard@redhat.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/sctp_diag.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c index bb69153..f3508aa 100644 --- a/net/sctp/sctp_diag.c +++ b/net/sctp/sctp_diag.c @@ -424,11 +424,13 @@ static int sctp_diag_dump_one(struct sk_buff *in_skb, paddr.v4.sin_family = AF_INET; } else { laddr.v6.sin6_port = req->id.idiag_sport; - memcpy(&laddr.v6.sin6_addr, req->id.idiag_src, 64); + memcpy(&laddr.v6.sin6_addr, req->id.idiag_src, + sizeof(laddr.v6.sin6_addr)); laddr.v6.sin6_family = AF_INET6; paddr.v6.sin6_port = req->id.idiag_dport; - memcpy(&paddr.v6.sin6_addr, req->id.idiag_dst, 64); + memcpy(&paddr.v6.sin6_addr, req->id.idiag_dst, + sizeof(paddr.v6.sin6_addr)); paddr.v6.sin6_family = AF_INET6; } |
