diff options
| author | Wei Yongjun <yjwei@cn.fujitsu.com> | 2007-08-27 11:19:24 +0800 |
|---|---|---|
| committer | Vlad Yasevich <vladislav.yasevich@hp.com> | 2007-08-30 13:52:56 -0400 |
| commit | d99fa42963a5ae394cf1df9d5bb739eb378a189b (patch) | |
| tree | cfbad786d1115135ce7fc61ffef83018feadaa5b /net/sctp/sm_sideeffect.c | |
| parent | 00f1c2df2a1c4903f4daa1333bafeb6dcbc9591d (diff) | |
| download | op-kernel-dev-d99fa42963a5ae394cf1df9d5bb739eb378a189b.zip op-kernel-dev-d99fa42963a5ae394cf1df9d5bb739eb378a189b.tar.gz | |
SCTP: Use net_ratelimit to suppress error messages print too fast
When multi bundling SHUTDOWN-ACK message is received in ESTAB state,
this will cause "sctp protocol violation state" message print many times.
If SHUTDOWN-ACK is bundled 300 times in one packet, message will be
print 300 times. The same problem also exists when received unexpected
HEARTBEAT-ACK message which is bundled message times.
This patch used net_ratelimit() to suppress error messages print too fast.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Diffstat (limited to 'net/sctp/sm_sideeffect.c')
| -rw-r--r-- | net/sctp/sm_sideeffect.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c index 1907318..8d78900 100644 --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -1013,8 +1013,9 @@ static int sctp_side_effects(sctp_event_t event_type, sctp_subtype_t subtype, break; case SCTP_DISPOSITION_VIOLATION: - printk(KERN_ERR "sctp protocol violation state %d " - "chunkid %d\n", state, subtype.chunk); + if (net_ratelimit()) + printk(KERN_ERR "sctp protocol violation state %d " + "chunkid %d\n", state, subtype.chunk); break; case SCTP_DISPOSITION_NOT_IMPL: |
