diff options
| author | Lars Persson <lars.persson@axis.com> | 2016-04-12 08:45:52 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-04-14 01:28:51 -0400 |
| commit | 3dcd493fbebfd631913df6e2773cc295d3bf7d22 (patch) | |
| tree | 24b9dbc71e8bb88416b659a25f843ef85a81403f /net/sched | |
| parent | 309cf37fe2a781279b7675d4bb7173198e532867 (diff) | |
| download | op-kernel-dev-3dcd493fbebfd631913df6e2773cc295d3bf7d22.zip op-kernel-dev-3dcd493fbebfd631913df6e2773cc295d3bf7d22.tar.gz | |
net: sched: do not requeue a NULL skb
A failure in validate_xmit_skb_list() triggered an unconditional call
to dev_requeue_skb with skb=NULL. This slowly grows the queue
discipline's qlen count until all traffic through the queue stops.
We take the optimistic approach and continue running the queue after a
failure since it is unknown if later packets also will fail in the
validate path.
Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock")
Signed-off-by: Lars Persson <larper@axis.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_generic.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index f18c350..80742ed 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -159,12 +159,15 @@ int sch_direct_xmit(struct sk_buff *skb, struct Qdisc *q, if (validate) skb = validate_xmit_skb_list(skb, dev); - if (skb) { + if (likely(skb)) { HARD_TX_LOCK(dev, txq, smp_processor_id()); if (!netif_xmit_frozen_or_stopped(txq)) skb = dev_hard_start_xmit(skb, dev, txq, &ret); HARD_TX_UNLOCK(dev, txq); + } else { + spin_lock(root_lock); + return qdisc_qlen(q); } spin_lock(root_lock); |
