diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2010-06-05 11:17:36 -0600 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2010-06-05 11:17:37 +0930 |
commit | 3bafeb6247042dcbb72b0141ec7c7107de9f0b99 (patch) | |
tree | f9b8f2437455332cd64d94bedb0836ac0f2b6fd9 /net/rfkill | |
parent | 75676500f8298f0ee89db12db97294883c4b768e (diff) | |
download | op-kernel-dev-3bafeb6247042dcbb72b0141ec7c7107de9f0b99.zip op-kernel-dev-3bafeb6247042dcbb72b0141ec7c7107de9f0b99.tar.gz |
module: move find_module check to end
I think Rusty may have made the lock a bit _too_ finegrained there, and
didn't add it to some places that needed it. It looks, for example, like
PATCH 1/2 actually drops the lock in places where it's needed
("find_module()" is documented to need it, but now load_module() didn't
hold it at all when it did the find_module()).
Rather than adding a new "module_loading" list, I think we should be able
to just use the existing "modules" list, and just fix up the locking a
bit.
In fact, maybe we could just move the "look up existing module" a bit
later - optimistically assuming that the module doesn't exist, and then
just undoing the work if it turns out that we were wrong, just before
adding ourselves to the list.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'net/rfkill')
0 files changed, 0 insertions, 0 deletions