summaryrefslogtreecommitdiffstats
path: root/net/rfkill
diff options
context:
space:
mode:
authorIvo van Doorn <IvDoorn@gmail.com>2007-05-19 12:24:39 -0700
committerDavid S. Miller <davem@davemloft.net>2007-05-19 12:24:39 -0700
commitd007da1fa6f0ad5e01ceae4a1f60cdbb23ecd706 (patch)
treefa96a04b86164d8256e1c4fb533236148fcb0c4e /net/rfkill
parentc34b19fb4e243b26fa90a322bf32238356493674 (diff)
downloadop-kernel-dev-d007da1fa6f0ad5e01ceae4a1f60cdbb23ecd706.zip
op-kernel-dev-d007da1fa6f0ad5e01ceae4a1f60cdbb23ecd706.tar.gz
[RFKILL]: Fix check for correct rfkill allocation
coverity has spotted a bug in rfkill.c (bug id #1627), in rfkill_allocate() NULL was returns if the kzalloc() works, and deref the NULL pointer if it fails, Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rfkill')
-rw-r--r--net/rfkill/rfkill.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
index a973603..f3986d4 100644
--- a/net/rfkill/rfkill.c
+++ b/net/rfkill/rfkill.c
@@ -296,7 +296,7 @@ struct rfkill *rfkill_allocate(struct device *parent, enum rfkill_type type)
struct device *dev;
rfkill = kzalloc(sizeof(struct rfkill), GFP_KERNEL);
- if (rfkill)
+ if (!rfkill)
return NULL;
mutex_init(&rfkill->mutex);
OpenPOWER on IntegriCloud