diff options
author | Santosh Shilimkar <santosh.shilimkar@oracle.com> | 2015-09-11 15:44:29 -0700 |
---|---|---|
committer | Santosh Shilimkar <santosh.shilimkar@oracle.com> | 2015-10-05 11:19:01 -0700 |
commit | db6526dcb51b054961a2d96ba43dec23e38818b3 (patch) | |
tree | 37d72344806ac00cf13ed36e59b08cba1f882a02 /net/rds/threads.c | |
parent | 4bebdd7a4d2960b2ff6c40b27156d041ea270765 (diff) | |
download | op-kernel-dev-db6526dcb51b054961a2d96ba43dec23e38818b3.zip op-kernel-dev-db6526dcb51b054961a2d96ba43dec23e38818b3.tar.gz |
RDS: use rds_send_xmit() state instead of RDS_LL_SEND_FULL
In Transport indepedent rds_sendmsg(), we shouldn't make decisions based
on RDS_LL_SEND_FULL which is used to manage the ring for RDMA based
transports. We can safely issue rds_send_xmit() and the using its
return value take decision on deferred work. This will also fix
the scenario where at times we are seeing connections stuck with
the LL_SEND_FULL bit getting set and never cleared.
We kick krdsd after any time we see -ENOMEM or -EAGAIN from the
ring allocation code.
Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Diffstat (limited to 'net/rds/threads.c')
-rw-r--r-- | net/rds/threads.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/rds/threads.c b/net/rds/threads.c index dc2402e..454aa6d 100644 --- a/net/rds/threads.c +++ b/net/rds/threads.c @@ -162,7 +162,9 @@ void rds_send_worker(struct work_struct *work) int ret; if (rds_conn_state(conn) == RDS_CONN_UP) { + clear_bit(RDS_LL_SEND_FULL, &conn->c_flags); ret = rds_send_xmit(conn); + cond_resched(); rdsdebug("conn %p ret %d\n", conn, ret); switch (ret) { case -EAGAIN: |