diff options
| author | Andy Grover <andy.grover@oracle.com> | 2010-03-11 13:49:55 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-03-16 21:16:53 -0700 |
| commit | 735f61e62611161588123930823af6e6a9fd5c2c (patch) | |
| tree | d07e16026909daa692ddab9c7b0801cc418cb3bc /net/rds/ib_recv.c | |
| parent | 87faf3ccf1c939938600ab57c6c9ed5bd2e5f4cc (diff) | |
| download | op-kernel-dev-735f61e62611161588123930823af6e6a9fd5c2c.zip op-kernel-dev-735f61e62611161588123930823af6e6a9fd5c2c.tar.gz | |
RDS: Do not BUG() on error returned from ib_post_send
BUGging on a runtime error code should be avoided. This
patch also eliminates all other BUG()s that have no real
reason to exist.
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds/ib_recv.c')
| -rw-r--r-- | net/rds/ib_recv.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index 04dc0d3..c338881 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -468,8 +468,8 @@ static void rds_ib_send_ack(struct rds_ib_connection *ic, unsigned int adv_credi set_bit(IB_ACK_REQUESTED, &ic->i_ack_flags); rds_ib_stats_inc(s_ib_ack_send_failure); - /* Need to finesse this later. */ - BUG(); + + rds_ib_conn_error(ic->conn, "sending ack failed\n"); } else rds_ib_stats_inc(s_ib_ack_sent); } |
