summaryrefslogtreecommitdiffstats
path: root/net/packet
diff options
context:
space:
mode:
authordanborkmann@iogearbox.net <danborkmann@iogearbox.net>2011-10-10 06:52:46 +0000
committerDavid S. Miller <davem@davemloft.net>2011-10-10 14:09:08 -0400
commit95f5f803b3897f622c4b5f72d554874faf74df12 (patch)
tree7241563ed75f0ee7443df99bbbb304c0a870496a /net/packet
parent5bdc4f5de1345c221f5b51d73fafe3e5de718a54 (diff)
downloadop-kernel-dev-95f5f803b3897f622c4b5f72d554874faf74df12.zip
op-kernel-dev-95f5f803b3897f622c4b5f72d554874faf74df12.tar.gz
af_packet: remove unnecessary BUG_ON() in tpacket_destruct_skb
If skb is NULL, then stack trace is thrown anyway on dereference. Therefore, the stack trace triggered by BUG_ON is duplicate. Signed-off-by: Daniel Borkmann <danborkmann@googlemail.com> Cc: Eric Dumazet <eric.dumazet@gmail.com> Acked-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/packet')
-rw-r--r--net/packet/af_packet.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index dac91abf..7b5f032 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -1968,8 +1968,6 @@ static void tpacket_destruct_skb(struct sk_buff *skb)
struct packet_sock *po = pkt_sk(skb->sk);
void *ph;
- BUG_ON(skb == NULL);
-
if (likely(po->tx_ring.pg_vec)) {
ph = skb_shinfo(skb)->destructor_arg;
BUG_ON(__packet_get_status(po, ph) != TP_STATUS_SENDING);
OpenPOWER on IntegriCloud