diff options
| author | Denis ChengRq <crquan@gmail.com> | 2014-06-02 01:18:01 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-06-02 10:36:18 -0700 |
| commit | 2f91abd4516da0cadfb955c963b16f96e2e6c07a (patch) | |
| tree | 551d9c8f4bfe699eeb731f108e3842d9498c5144 /net/netlink/genetlink.c | |
| parent | 96b2e73c5471542cb9c622c4360716684f8797ed (diff) | |
| download | op-kernel-dev-2f91abd4516da0cadfb955c963b16f96e2e6c07a.zip op-kernel-dev-2f91abd4516da0cadfb955c963b16f96e2e6c07a.tar.gz | |
genetlink: remove superfluous assignment
the local variable ops and n_ops were just read out from family,
and not changed, hence no need to assign back.
Validation functions should operate on const parameters and not
change anything.
Signed-off-by: Cheng Renquan <crquan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink/genetlink.c')
| -rw-r--r-- | net/netlink/genetlink.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index a3ba3ca..76393f2 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -317,7 +317,7 @@ static void genl_unregister_mc_groups(struct genl_family *family) } } -static int genl_validate_ops(struct genl_family *family) +static int genl_validate_ops(const struct genl_family *family) { const struct genl_ops *ops = family->ops; unsigned int n_ops = family->n_ops; @@ -337,10 +337,6 @@ static int genl_validate_ops(struct genl_family *family) return -EINVAL; } - /* family is not registered yet, so no locking needed */ - family->ops = ops; - family->n_ops = n_ops; - return 0; } |
