summaryrefslogtreecommitdiffstats
path: root/net/netlabel
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2009-07-30 04:38:19 +0000
committerDavid S. Miller <davem@davemloft.net>2009-07-30 10:58:28 -0700
commitca7daea612b480ecf0fc5bd1630b88447fe73fc5 (patch)
tree4fa3d875d3fdc7a3e33cac4a5e20d78d77948685 /net/netlabel
parenta1b97440eec0ea3e53183cde8fe82ff8c1ffb091 (diff)
downloadop-kernel-dev-ca7daea612b480ecf0fc5bd1630b88447fe73fc5.zip
op-kernel-dev-ca7daea612b480ecf0fc5bd1630b88447fe73fc5.tar.gz
net/netlabel: Add kmalloc NULL tests
The test on map4 should be a test on map6. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression *x; identifier f; constant char *C; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(...); ... when != x == NULL when != x != NULL when != (x || ...) ( kfree(x) | f(...,C,...,x,...) | *f(...,x,...) | *x->f ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Paul Moore <paul.moore@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlabel')
-rw-r--r--net/netlabel/netlabel_kapi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
index b0e582f..16e6c43 100644
--- a/net/netlabel/netlabel_kapi.c
+++ b/net/netlabel/netlabel_kapi.c
@@ -151,7 +151,7 @@ int netlbl_cfg_unlbl_map_add(const char *domain,
addr6 = addr;
mask6 = mask;
map6 = kzalloc(sizeof(*map6), GFP_ATOMIC);
- if (map4 == NULL)
+ if (map6 == NULL)
goto cfg_unlbl_map_add_failure;
map6->type = NETLBL_NLTYPE_UNLABELED;
ipv6_addr_copy(&map6->list.addr, addr6);
OpenPOWER on IntegriCloud