diff options
author | Eric Dumazet <edumazet@google.com> | 2014-06-06 06:44:03 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-06-08 14:15:14 -0700 |
commit | 87757a917b0b3c0787e0563c679762152be81312 (patch) | |
tree | ffc8bfa37fc3db09ac90bff273fbf13085e8d558 /net/mac80211 | |
parent | ba6de0f5304ccdc45ae260e7e0feb6e0ef2dd558 (diff) | |
download | op-kernel-dev-87757a917b0b3c0787e0563c679762152be81312.zip op-kernel-dev-87757a917b0b3c0787e0563c679762152be81312.tar.gz |
net: force a list_del() in unregister_netdevice_many()
unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.
See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mac80211')
-rw-r--r-- | net/mac80211/iface.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index b8d331e..34799e0 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1758,7 +1758,6 @@ void ieee80211_remove_interfaces(struct ieee80211_local *local) } mutex_unlock(&local->iflist_mtx); unregister_netdevice_many(&unreg_list); - list_del(&unreg_list); list_for_each_entry_safe(sdata, tmp, &wdev_list, list) { list_del(&sdata->list); |