diff options
author | Johannes Berg <johannes.berg@intel.com> | 2017-03-08 11:12:10 +0100 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2017-03-08 14:20:01 +0100 |
commit | e8e4f5280ddd0a7b43a795f90a0758e3c99df6a6 (patch) | |
tree | 749391b6ba269af098d9ee4810b1dc24abf86d4a /net/mac80211/mlme.c | |
parent | b61fbda180b5c9f5f3ce7f2e63b0253c84ffdf09 (diff) | |
download | op-kernel-dev-e8e4f5280ddd0a7b43a795f90a0758e3c99df6a6.zip op-kernel-dev-e8e4f5280ddd0a7b43a795f90a0758e3c99df6a6.tar.gz |
mac80211: reject/clear user rate mask if not usable
If the user rate mask results in no (basic) rates being usable,
clear it. Also, if we're already operating when it's set, reject
it instead.
Technically, selecting basic rates as the criterion is a bit too
restrictive, but calculating the usable rates over all stations
(e.g. in AP mode) is harder, and all stations must support the
basic rates. Similarly, in client mode, the basic rates will be
used anyway for control frames.
This fixes the "no supported rates (...) in rate_mask ..." warning
that occurs on TX when you've selected a rate mask that's not
compatible with the connection (e.g. an AP that enables only the
rates 36, 48, 54 and you've selected only 6, 9, 12.)
Reported-by: Kirtika Ruchandani <kirtika@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/mlme.c')
-rw-r--r-- | net/mac80211/mlme.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 4b4d29e..24d69bc 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -1908,6 +1908,8 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata, sdata->u.mgd.associated = cbss; memcpy(sdata->u.mgd.bssid, cbss->bssid, ETH_ALEN); + ieee80211_check_rate_mask(sdata); + sdata->u.mgd.flags |= IEEE80211_STA_RESET_SIGNAL_AVE; if (sdata->vif.p2p || |